[TF2] Fix Half-Zatoichi honor kill being survivable with damage reduction runes#1852
Open
PhiTiet wants to merge 2 commits intoValveSoftware:masterfrom
Open
[TF2] Fix Half-Zatoichi honor kill being survivable with damage reduction runes#1852PhiTiet wants to merge 2 commits intoValveSoftware:masterfrom
PhiTiet wants to merge 2 commits intoValveSoftware:masterfrom
Conversation
Contributor
|
It's what I initially did on #1691 except with |
Author
|
@JoriKos Your exact suggestion is implemented correctly now: the Half-Zatoichi honor-bound duel kill uses a dedicated custom damage type and cleanly bypasses resist-rune reduction instead of inflating the damage value. |
Contributor
|
Now it's pretty much the same as my PR, but it doesn't bypass regular damage resistance. Issue is that basically copying #1691 isn't very productive unless it superceeds it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ValveSoftware/Source-1-Games#6974
The honor-bound one-shot uses
GetHealth() * 3. The Resist rune's 0.5x multiplier applied downstream can reduce this below lethal, especially when stacked with other reductions. Increased to* 10.